feat(avm): avm recursive verifier cpp #8162

jeanmon · 2024-08-23T15:22:20Z

Resolves #7790
Resolves #7816
The current version does not enable checks related to public inputs. This will be handled as part of #7817

AztecBot · 2024-08-23T16:02:22Z

Benchmark results

Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 661 (-52%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,759	1,564	714	755 (-1%)	776
proof_construction_time_sha256_30_ms	11,494 (-1%)	3,088 (-1%)	1,387 (-2%)	1,439 (-1%)	1,466 (-2%)
proof_construction_time_sha256_100_ms	44,210	11,910 (+1%)	5,460 (+1%)	5,659 (-3%)	5,751 (+1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0 (-28%)	34.0	58.0 (+2%)	88.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,529	422	203	225	269 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,650	1,506 (-1%)	671 (-1%)	729 (-1%)	745 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,244	92,952	178,216
l1_rollup_execution_gas	845,790	1,579,394	3,364,714
l2_block_processing_time_in_ms	257 (+2%)	448	818 (-1%)
l2_block_building_time_in_ms	11,405	22,268	44,336
l2_block_rollup_simulation_time_in_ms	11,405	22,268	44,336
l2_block_public_tx_process_time_in_ms	9,685	20,573	42,598

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,005 (+2%)	3,910 (+3%)
node_database_size_in_bytes	12,644,432	16,732,240
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	94.3 (-1%)	395	21,735	44,860	N/A
private-kernel-inner	174 (+1%)	702	72,544	45,007	N/A
private-kernel-reset-tiny	309	719 (-3%)	65,593	44,846	N/A
private-kernel-tail	167	137 (+1%)	50,644	52,257	N/A
base-parity	5.73 (+3%)	N/A	160	96.0	N/A
root-parity	36.0	N/A	73,948	96.0	N/A
base-rollup	2,980 (+1%)	N/A	189,136	664	N/A
block-root-rollup	42.2 (+2%)	N/A	58,205	2,448	N/A
public-kernel-setup	85.5 (+1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.7	N/A	104,911	71,222	N/A
public-kernel-tail	856	N/A	390,582	16,414	N/A
private-kernel-reset-small	311 (+1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 661 (-52%)	619	455,400	1,825	N/A
public-kernel-teardown	84.2	N/A	105,349	71,222	N/A
merge-rollup	20.3 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	77,361 (-2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	348 (+2%)
ContractInstanceDeployer:deploy	1,408	11,731	18.4 (+1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	409 (+1%)
FeeJuice:deploy	1,376	11,731	399 (+3%)
SchnorrAccount:constructor	1,312	11,731	73.4
SchnorrAccount:entrypoint	2,336	11,731	400 (+2%)
Token:privately_mint_private_note	1,280	11,731	105 (+3%)
FPC:fee_entrypoint_public	1,344	11,731	29.0 (+14%)
Token:transfer	1,312	11,731	237 (+3%)
Benchmarking:create_note	1,344	11,731	86.9 (+2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.9 (+1%)
Token:unshield	1,376	11,731	528 (+2%)
FPC:fee_entrypoint_private	1,376	11,731	703 (+2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	60.1 (+5%)	8,174
FeeJuice:set_portal	12.5 (+14%)	4,055
Token:constructor	90.1 (+11%)	29,082
FPC:constructor	55.4 (+2%)	18,940
FeeJuice:mint_public	41.0	6,522
Token:mint_public	53.5 (+13%)	12,704
Token:assert_minter_and_mint	318	8,467
AuthRegistry:set_authorized	40.6 (-17%)	4,194
FPC:prepare_fee	242 (+1%)	6,747
Token:transfer_public	25.4 (-15%)	39,863
FPC:pay_refund	54.8 (-13%)	9,398
Benchmarking:increment_balance	1,215	7,263
Token:_increase_public_balance	43.6 (-25%)	8,686
FPC:pay_refund_with_shielded_rebate	65.2 (+5%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.165 (+4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.37 (+8%)	3.98 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.124 (+8%)	0.113 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3 (+1%)	18.2 (+4%)	30.7	59.7 (+2%)	113 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.109 (+1%)	0.106 (+4%)	0.0997	0.103 (+2%)	0.101 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (+1%)	25.6 (-1%)	43.5 (+1%)	82.5 (-1%)	160 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110 (+1%)	0.103 (-1%)	0.105 (+1%)	0.102	0.101 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.6	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

barretenberg/cpp/src/barretenberg/vm/avm/generated/relations/alu_recursive.hpp

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_flavor.hpp

barretenberg/cpp/src/barretenberg/vm/avm/generated/flavor.hpp

barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_flavor.hpp

barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_verifier.hpp

barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_verifier.test.cpp

maramihali

LGTM! Left a few suggestions and a request to link an issue.

barretenberg/cpp/src/barretenberg/vm/CMakeLists.txt

barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_flavor.hpp

barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_verifier.cpp

barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_verifier.test.cpp

Maddiaa0 · 2024-08-29T09:21:16Z

barretenberg/cpp/src/barretenberg/vm/avm/generated/verifier.cpp

@@ -15,13 +15,11 @@ AvmVerifier::AvmVerifier(std::shared_ptr<Flavor::VerificationKey> verifier_key)

 AvmVerifier::AvmVerifier(AvmVerifier&& other) noexcept


barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_verifier.cpp

* master: (28 commits) chore: bump noir-bignum to 0.3.2 (#8276) feat: Populate epoch 0 from initial validator set (#8286) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore(master): Release 0.51.1 (#8218) feat(avm): integrate new range and cmp gadgets (#8165) chore: rename process to propose for clarity (#8265) chore: Bump provernet agents to 8 and speed up bot (#8280) feat(avm): avm recursive verifier cpp (#8162) feat: moving fee payout + make proof submission sequential (#8262) feat: Block cheat codes in anvil (#8277) feat: wallet tx management (#8246) refactor(avm): replace range and cmp with gadgets (#8164) fix(docs): Update entrypoint details on accounts page (#8184) feat: l1-publisher cleanup (#8148) feat(avm): range check gadget (#7967) fix(ci): spot-runner-action was not built (#8274) fix: ts codegen (#8267) ...

Resolves #7790 Resolves #7816 The current version does not enable checks related to public inputs. This will be handled as part of #7817

jeanmon force-pushed the jm/7790-avm-recursive-verifier-cpp branch 7 times, most recently from ce0c5ac to 18e2cc4 Compare August 28, 2024 12:31

jeanmon marked this pull request as ready for review August 28, 2024 12:39

jeanmon requested review from IlyasRidhuan, fcarreiro and Maddiaa0 as code owners August 28, 2024 12:39

jeanmon requested a review from maramihali August 28, 2024 12:50

jeanmon force-pushed the jm/7790-avm-recursive-verifier-cpp branch from 18e2cc4 to 80fc9e9 Compare August 28, 2024 13:00

fcarreiro reviewed Aug 28, 2024

View reviewed changes

maramihali approved these changes Aug 28, 2024

View reviewed changes

Maddiaa0 reviewed Aug 29, 2024

View reviewed changes

barretenberg/cpp/src/barretenberg/vm/avm/recursion/avm_recursive_verifier.cpp Show resolved Hide resolved

jeanmon force-pushed the jm/7790-avm-recursive-verifier-cpp branch 3 times, most recently from d1f935d to 85867e3 Compare August 29, 2024 18:38

jeanmon added 9 commits August 29, 2024 19:52

7790: Port cpp changes

7409b1f

7790: port codegen part

2b4a8a7

7790: Fix compilation issues

5947d16

7790: WIP - debugging assertion in from_witness()

9a19ae6

7790: Fix for zeromorph verification issue

0e7382f

7790: fix issues after rebase to master

3cfc1c4

7790: Clean up header files

79dc2bf

7790: cosmetic cleanups and assert circuit size

b803a26

7790: Enable Zeromorph in AVM recursive verifier (just compilation)

d503611

jeanmon added 12 commits August 29, 2024 19:52

7790: refactor - move pcs_verification_key to verification_key

c08f5d7

7790: Make Zeromorph verification work in AVM recursive verifier

8e6adf6

7790: recursive verifier returns pairing pooints + other improvements

6fba30c

7790: Cleaning up recursive flavor

4ba25b2

7790: Remove BATCHED_RELATION_TOTAL_LENGTH constant in all flavors

e180d60

7790: additional clean ups

31d29e3

7790: Keep certain classes in flavor.hpp private

ad67582

7790: some review feedback is addressed

68e3dde

7790: remove _recursive.hpp generated files

f2021ec

7790: remove code-gen related to recursive files

4bc2381

7790: some other review comments are addressed

33c16ad

7790: resolve conflict after rebase on master

84412e7

jeanmon force-pushed the jm/7790-avm-recursive-verifier-cpp branch from 85867e3 to 84412e7 Compare August 29, 2024 19:55

jeanmon merged commit 6a5587c into master Aug 29, 2024
100 checks passed

jeanmon deleted the jm/7790-avm-recursive-verifier-cpp branch August 29, 2024 20:54

AztecBot mentioned this pull request Aug 29, 2024

chore(master): Release 0.51.1 #8218

Merged

codygunton pushed a commit that referenced this pull request Aug 30, 2024

feat(avm): avm recursive verifier cpp (#8162)

4f1b52b

Resolves #7790 Resolves #7816 The current version does not enable checks related to public inputs. This will be handled as part of #7817

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): avm recursive verifier cpp #8162

feat(avm): avm recursive verifier cpp #8162

jeanmon commented Aug 23, 2024 •

edited

Loading

AztecBot commented Aug 23, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

maramihali left a comment

Maddiaa0 Aug 29, 2024

		@@ -15,13 +15,11 @@ AvmVerifier::AvmVerifier(std::shared_ptr<Flavor::VerificationKey> verifier_key)

		AvmVerifier::AvmVerifier(AvmVerifier&& other) noexcept

feat(avm): avm recursive verifier cpp #8162

feat(avm): avm recursive verifier cpp #8162

Conversation

jeanmon commented Aug 23, 2024 • edited Loading

AztecBot commented Aug 23, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

maramihali left a comment

Choose a reason for hiding this comment

Maddiaa0 Aug 29, 2024

Choose a reason for hiding this comment

jeanmon commented Aug 23, 2024 •

edited

Loading

AztecBot commented Aug 23, 2024 •

edited

Loading